Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

and-semakin
Copy link

Thanks for the library!

It's already the end of 2021. Seems like it's a good moment to drop Python 2 support 😅

@dnet
Copy link
Owner

dnet commented Oct 26, 2021

What's the potential gain? This project has a laser sharp scope, it does one thing and it does that well. It's not like future development efforts are hampered by having some conditional macros in the C code. I agree that not many people should expect any support for Python 2 in 2021, so the downside is not that bad. I just can't see the what the project could gain from removing the option. Change my mind :)

@and-semakin
Copy link
Author

Well, not sure if I'll find a good enough argument to convince you :)

It will become more difficult to test this library on Python 2 every year. Probably, in 5 years or so there will be no Python 2 pre-installed on MacOS and Linux. Breaking changes in some libraries will prevent you from building it from source (like OpenSSL 1.0 vs 1.1, it already makes it difficult to compile old Pythons). I agree that supporting Python 2 doesn't require any effort at the moment. It's not likely that something will change in Python 2. But Python 3 will definitely change and require updates. At some point, after a fix required for Python 3, you won't be even able to validate that it still works on Python 2. So, you'll have to drop it anyway sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants